Fixed argument/parameter usage of urdf macro #482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed "use_fake_hardware" and "fake_sensor_commands" from argument to parameter.
|
This is not only affecting those. This has been fixed from galactic up, but was not backported to Foxy, yet. Thanks for pointing that out! The Foxy description seems to need some more attention.... |
|
Ah i see, i was only working with the Foxy branch because its our main ROS branch right now and i had a tight deadline (as always ;D) Are there any Galatic / Humble specific changes within the new description repository or is it maybe possible to just use the new package as a submodule in Foxy too? |
|
As far as I remember, there were some major changes, especially regarding the ros2_control integration, so I wouldn't expect that you can simply use that on a Foxy setup. |
|
Closing in favor of #495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"use_fake_hardware" and "fake_sensor_commands" are used as arguments instead of params. This required external urdf files that will use these macro to declare these two values as arguments instead of passing them via marcro parameter.